fix(filter): respect preserve_tags in excluded_tags removal (#2125) - #2193
Open
Battleplus wants to merge 1 commit into
Open
fix(filter): respect preserve_tags in excluded_tags removal (#2125)#2193Battleplus wants to merge 1 commit into
Battleplus wants to merge 1 commit into
Conversation
…e#2125) _prune_tree already respects preserve_tags via _is_preserved(), but _remove_unwanted_tags runs first and decomposes all excluded tags (nav, footer, header, aside, ...) unconditionally. So PruningContentFilter(preserve_tags=["aside"]) was silently ignored. Add preserve_tags check in _remove_unwanted_tags to skip elements whose tag is in the preserve whitelist. Closes unclecode#2125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2125 — PruningContentFilter(preserve_tags=["aside"]) was silently ignored because _remove_unwanted_tags decomposes all excluded tags (nav, footer, header, aside, ...) before _prune_tree runs.
Root cause
_remove_unwanted_tags() decomposes every element in self.excluded_tags unconditionally. _prune_tree() respects preserve_tags via _is_preserved(), but the elements are already gone.
Fix
Add preserve_tags check in _remove_unwanted_tags to skip elements whose tag is in the preserve whitelist.
Files changed