Skip to content

fix(filter): respect preserve_tags in excluded_tags removal (#2125) #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Battleplus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(filter): respect preserve_tags in excluded_tags removal (#2125) #2193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion crawl4ai/content_filter_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,9 +683,14 @@ def _remove_comments(self, soup):
element.extract()

def _remove_unwanted_tags(self, soup):
"""Removes unwanted tags"""
"""Removes unwanted tags, respecting preserve_tags whitelist."""
for tag in self.excluded_tags:
for element in soup.find_all(tag):
# Skip elements that match preserve_tags — they should be kept
# even if the tag is in excluded_tags (e.g., <aside> with
# preserve_tags=["aside"]). See #2125.
if self.preserve_tags and tag in self.preserve_tags:
continue
element.decompose()

def _is_preserved(self, node):
Expand Down