Skip to content

Skip validation when accessing storage scalar of extension scalar - #9875

Open
robert3005 wants to merge 2 commits into
developfrom
rk/storagevalid
Open

robert3005 wants to merge 2 commits into
developfrom
rk/storagevalid

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

This was already validated and current implementation panics

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/chore A trivial change label Sep 14, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@codspeed

codspeed Bot commented Sep 14, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 5 improved benchmarks
❌ 1 regressed benchmark
✅ 2192 untouched benchmarks
⏩ 218 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime dict_canonicalize_gt_u8_avx512[16000000] 6.8 ms 12.6 ms -46.5%
WallTime arrow_checked_add_u32_avx2[16384] 21.4 µs 17.6 µs +21.28%
WallTime words_gather_scalar_avx2[65536] 9.4 µs 8.2 µs +13.75%
Simulation allocate_drop_arrow[0] 456.9 ns 402.7 ns +13.45%
WallTime dict_canonicalize_gt_u8_avx2[16000000] 7.6 ms 6.8 ms +11.42%
Simulation allocate_drop_bytes[0] 575.7 ns 521.6 ns +10.39%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/storagevalid (dd50732) with develop (7286721)

Open in CodSpeed

Footnotes

  1. 218 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005
robert3005 enabled auto-merge (squash) September 15, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant