Skip to content

Skip validation when accessing storage scalar of extension scalar #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robert3005 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Skip validation when accessing storage scalar of extension scalar #9875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be2f3e
Skip validation when accessing storage scalar of extension scalar
robert3005 Sep 14, 2026
dd50732
more
robert3005 Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vortex-array/src/scalar/typed_view/extension/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
use std::fmt;
use std::hash::Hash;

use vortex_error::VortexExpect;
use vortex_error::VortexResult;
use vortex_error::vortex_bail;
use vortex_error::vortex_panic;
Expand Down Expand Up @@ -75,8 +74,9 @@ impl<'a> ExtScalar<'a> {

/// Returns the storage scalar of the extension scalar.
pub fn to_storage_scalar(&self) -> Scalar {
Scalar::try_new(self.ext_dtype.storage_dtype().clone(), self.value.cloned())
.vortex_expect("ExtScalar is invalid")
unsafe {
Scalar::new_unchecked(self.ext_dtype.storage_dtype().clone(), self.value.cloned())
}
}

/// Returns a reference to the underlying value
Expand Down
Loading