configs: the bridgemill M428 remap selects the TCP kinematics with G12.1 P0 - #4534
Merged
Merged
Conversation
…2.1 P0 On 5axiskins type 0 is the TCP kinematics and type 1 the identity, and G13.1 goes to the identity, so the remap that meant "back to type 0" landed on the identity kinematics instead. Say G12.1 P0, which is what it meant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 5axiskins type 0 is the TCP kinematics and type 1 the identity. The bridgemill sim's M428 remap says
G13.1to go "back to kinstype 0", but since #4414G13.1goes to the kinematics the module declares as identity, which is type 1 here, so M428 leaves the machine on the identity kinematics (motion.kins-typestays 1).G12.1 P0is what it meant; the other sims already say it that way.