AOT: fix bare self/parent typed property assigns from locals (#31835) - #35705
Merged
Conversation
VM resolved self/parent in 31841 but native TYPE_OBJECT property slots still stored boxed __value__ operands via the value-box path, yielding garbage reads. Read __object__* from value boxes on store and enforce class constraints with catchable TypeErrors matching Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_OBJECTproperty stores when the RHS is a boxed local (__value__→__object__*via__value__readObject) — the value-box path was writing to object slots and reads returned garbage (WeakRefRegistryJitHelper, etc.).classConstraintmetadata on JIT property slots and enforce catchableTypeErrors for bareself/parent/class-typed properties under AOT (VM fixed in Language: early-bind bare self/parent property types (#31835) #31841; AOT was still open).Closes #31835
Test plan
Made with Cursor