MT-23076: add --expires-at to tokens create and reset - #12
Draft
oshchyhol wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
The API token endpoints now accept an
expires_atattribute. The CLI needs a way to set a token expiry on create and reset, including the explicit "never expires" case.Changes
tokens creategains an--expires-atflag mapped to theexpires_atparam of thecreateApiTokenoperation (POST /api/api_tokens)tokens resetgains the same flag mapped to the now-optional request body of theresetApiTokenoperation (POST /api/api_tokens/{id}/reset); without the flag the command still posts no body, exactly as before--expires-at never(case-insensitive sentinel) – explicit"expires_at": null, token never expires; any other value – passed through verbatim as a stringskills/mailtrap-cli/references/accounts.mdflag tablesHow to test
mailtrap tokens create --name t1 --permissions '[...]'(no--expires-at) – request body has noexpires_atkey; the created token gets the server default expirymailtrap tokens create --name t2 --permissions '[...]' --expires-at 2027-06-01T00:00:00Z– token is created with that expiry, EXPIRES_AT column shows itmailtrap tokens create --name t3 --permissions '[...]' --expires-at never(also tryNEVER) – token is created without an expirymailtrap tokens create --name t4 --permissions '[...]' --expires-at 2020-01-01T00:00:00Z– command exits non-zero and prints the server 422 error to stderrmailtrap tokens reset --id <id>(no--expires-at) – behaves exactly as before this change: empty request body, new token value printedmailtrap tokens reset --id <id> --expires-at 2027-06-01T00:00:00Zand--expires-at never– new token gets that expiry / no expirymailtrap tokens list/tokens get --id <id>– unchanged, EXPIRES_AT column still rendersCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.