MT-23076: support api token expiration in create and reset - #75
Draft
oshchyhol wants to merge 6 commits into
Draft
MT-23076: support api token expiration in create and reset#75oshchyhol wants to merge 6 commits into
oshchyhol wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
The API token endpoints now accept an optional
expires_atvalue. This exposes it in the SDK so users can create or reset tokens with a specific expiry, no expiry, or the server default.Changes
TokenExpirationvalue object (src/DTO/Request/ApiToken/TokenExpiration.php) withTokenExpiration::at(DateTimeInterface|string)andTokenExpiration::never()named constructorscreateApiToken(OpenAPIcreateApiToken,CreateApiTokenRequest.expires_at) takes an optional?TokenExpiration $expiration– argument omitted → noexpires_atkey in the body (server default, a 1-year default is being rolled out),never()→"expires_at": null(never expires),at(...)→ the given ISO 8601 date-timeresetApiToken(OpenAPIresetApiToken, request body is now optional with the sameexpires_atparam) takes the same optional argument – without it the request still has no body at all, unchanged from the previous releaseHttpClientExceptionexamples/api-tokens/all.phpshows the new argument; README and examples index now list the api-tokens example under General APIHow to test
createApiToken($name, $permissions)without the new argument – the request body contains onlynameandresources(noexpires_atkey), the token is createdresetApiToken($id)without the new argument – the request is sent with no body at all, exactly as before this change, and returns the new token valuecreateApiToken($name, $permissions, TokenExpiration::at('2027-06-01T00:00:00Z'))– the body contains"expires_at": "2027-06-01T00:00:00Z"and the response echoes that expiryTokenExpiration::at(new DateTimeImmutable('2027-06-01T00:00:00+00:00'))– the DateTime is serialized as an ISO 8601 string in the bodycreateApiToken(..., TokenExpiration::never())andresetApiToken($id, TokenExpiration::never())– the body contains"expires_at": nulland the response token hasexpires_at: nullTokenExpiration::at('2020-01-01T00:00:00Z')(a past date) on create or reset – the server responds 422 and the SDK throwsHttpClientExceptionwith the server error messageCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.