MT-23076: support expires_at for api token create and reset - #122
Draft
oshchyhol wants to merge 5 commits into
Draft
MT-23076: support expires_at for api token create and reset#122oshchyhol wants to merge 5 commits into
oshchyhol wants to merge 5 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
The Mailtrap API token endpoints now accept an optional
expires_at. This exposes it in the Ruby SDK so tokens can be created or reset with an explicit expiry, with the server default, or as never-expiring.Changes
ApiTokensAPI#createacceptsexpires_at(thecreateApiTokenrequest param): omit for the server default (a 1-year default is being rolled out), pass an ISO 8601 date-time for an explicit expiry, or explicitnilfor a token that never expiresApiTokensAPI#resetaccepts an optional options hash withexpires_at(theresetApiTokenrequest body, which is optional in the spec); with no options it still sends no request body at allexpires_atkey from"expires_at": null– no client-side date validation, invalid values are rejected by the server with 422bin/record-vcronce it isHow to test
api_tokens.create(name: ..., resources: [...])withoutexpires_at– the request body has noexpires_atkey and the token is created exactly as beforeapi_tokens.create(..., expires_at: '2027-06-01T00:00:00Z')– the request body contains"expires_at":"2027-06-01T00:00:00Z"and the response token has that expiryapi_tokens.create(..., expires_at: nil)– the request body contains"expires_at":nulland the response token never expiresapi_tokens.create(..., expires_at: '2020-01-01T00:00:00Z')(past date) – raisesMailtrap::Errorfrom the server 422api_tokens.reset(token_id)with no options – no request body is sent at all (same as the previous SDK version) and a new token is returnedapi_tokens.reset(token_id, expires_at: '2027-06-01T00:00:00Z')andapi_tokens.reset(token_id, expires_at: nil)– the body is exactly{"expires_at":"2027-06-01T00:00:00Z"}/{"expires_at":null}api_tokens.create(unknown: true)andapi_tokens.reset(token_id, unknown: true)– raiseArgumentErrorbefore any request is madeCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.