MT-23076: support expires_at on api token create and reset - #149
Draft
oshchyhol wants to merge 4 commits into
Draft
MT-23076: support expires_at on api token create and reset#149oshchyhol wants to merge 4 commits into
oshchyhol wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
The API token endpoints now accept an optional
expires_at(createApiTokenrequest body and a new optionalresetApiTokenbody). This exposes it in the SDK.Changes
expires_at?: string | nulltoCreateApiTokenRequest(maps to theexpires_atparam of thecreateApiTokenoperation)ResetApiTokenRequesttype and an optionalparamsargument toapiTokens.reset(id, params?)(theresetApiTokenoperation now takes an optional body)paramsis omitted or has noexpires_atkey,resetsends no request body – identical to the previous behaviorexpires_at: nullis serialized as an explicit JSON null ("never expires"); omitting the key leaves the expiration to the server default (a 1-year default is being rolled out)How to test
apiTokens.create({ name, resources })withoutexpires_at– request body has noexpires_atkey, token is created as beforeapiTokens.create({ ..., expires_at: "2027-06-01T00:00:00Z" })– created token'sexpires_atmatches the passed valueapiTokens.create({ ..., expires_at: null })– created token never expires (expires_at: nullin the response)apiTokens.create({ ..., expires_at: "2020-01-01T00:00:00Z" })(past date) – rejected,MailtrapErrorwith the server's 422 messageapiTokens.reset(id)without params – no request body sent, reset works exactly as beforeapiTokens.reset(id, { expires_at: null })– new token never expiresapiTokens.reset(id, { expires_at: "<future date>" })– new token expires at the passed valueCompanion PRs
Caveat: release/merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production.